lkml.org 
[lkml]   [2008]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] swiotlb: fix dma_alloc_coherent allocation failures with swiotlb
    From
    On Wed, 3 Sep 2008 17:03:44 +0200
    Joerg Roedel <joerg.roedel@amd.com> wrote:

    > The SWIOTLB version of dma_alloc_coherent allocates all memory with
    > GFP_DMA unconditionally. This leads sometimes unnecessary to allocation
    > failures. This patch makes the allocation strategy to use the DMA32 zone
    > first if this is possible. The changes are boot tested on AMD64 and
    > compile tested for i386 and IA64.
    >
    > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > Cc: tony.luck@intel.com
    > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    > ---
    > lib/swiotlb.c | 23 +++++++++++++++++------
    > 1 files changed, 17 insertions(+), 6 deletions(-)

    This doesn't look correct since IA64 doesn't need this flag hack.

    Another problem about this patch is that swiotlb doesn't use GFP_DMA
    for the fallback_dev.

    I'll send patches to fix this problem differently.


    \
     
     \ /
      Last update: 2008-09-03 20:09    [W:0.139 / U:0.164 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean