Messages in this thread | | | Date | Wed, 3 Sep 2008 09:54:46 -0600 | From | Jonathan Corbet <> | Subject | Re: [PATCH 3/3] Define and use PCI_DEVICE_ID_MARVELL_88ALP01_CCIC for CAFÉ camera driver |
| |
On Wed, 03 Sep 2008 11:48:22 +0100 David Woodhouse <dwmw2@infradead.org> wrote:
> Also, stop looking at the NAND controller (0x4100) and checking the > device class. For a while during development, all three functions on > the chip had the same ID. We made them fix that fairly promptly, and > we can forget about it now.
I see no harm in having the driver check the device to ensure it's what it thinks it is - we can probably afford the runtime overhead. But whatever, I'm not that concerned; toss in an
Acked-by: Jonathan Corbet <corbet@lwn.net>
if you wish.
jon
| |