lkml.org 
[lkml]   [2008]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Path -tip 1/3] Tracing/ftrace: Change the type of the print_line callback
On Mon, 29 Sep 2008 11:11:15 +0200
"Frédéric Weisbecker" <fweisbec@gmail.com> wrote:

> 2008/9/28 Pekka Paalanen <pq@iki.fi>:
>

[static int print_trace_line(struct trace_iterator *iter)]

> > Shouldn't the return type be bool?
> > If it's not, reading this function makes me wonder about the conversion
> > from enum to int, i.e. what is the meaning of the int.
>
> Actually it should be enum print_line_t. I forgot to change its type.
> But we need to check its return value as an enum print_line_t.

Is print_line_t necessary? Does it have to return any other information than
"this entry was handled somehow" vs. "this entry must be handled later"?
Currently it's just a flag to say "please flush and retry".

--
Pekka Paalanen
http://www.iki.fi/pq/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-09-29 17:07    [W:0.083 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site