lkml.org 
[lkml]   [2008]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH git latest] drivers/net: fixing a datarace related to update_stats()
(Please Cc: netdev@vger.kernel.org)

Lin Tan <tammy000@gmail.com> :
[drivers/net/pcmcia/3c589_cs.c race]
> As indicated by the following comment, a lock must be held before calling
> function update_stats(). This rule is followed in some cases, but not in
> others. For example, the lock is held when the function is called in function
> el3_get_stats(), but the lock is NOT held when called in el3_close(). It can
> cause potential data races.

I would not bet that the irq handler does not race with el3_close()
in the first place. Could you dig it ?

--
Ueimor


\
 
 \ /
  Last update: 2008-09-27 23:47    [from the cache]
©2003-2011 Jasper Spaans