Messages in this thread | | | Date | Sat, 27 Sep 2008 19:42:33 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] - UV fix for size of hub mappings |
| |
* Jack Steiner <steiner@sgi.com> wrote:
> Fix the size of the mappings of UV hub registers. Size must be a > function of the maximum node number within the SSI. > > Signed-off-by: Jack Steiner <steiner@sgi.com>
applied to tip/x86/uv, thanks Jack!
i'm wondering, the code still has a couple of ZZZ fixmes like:
#ifdef ZZZ /* Needs x2apic patch */ static void uv_send_IPI_self(int vector) { apic_write(APIC_SELF_IPI, vector); } #endif
x2apic support is available in tip/master, so it would be nice to glue UV to generic x2apic support properly and remove duplication and fixmes. For example, do we really need apic_x2apic_uv_x, or could we use apic_x2apic_cluster?
Ingo
| |