lkml.org 
[lkml]   [2008]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD Driver available.
Hi Artem

we have following erro message if we maintain 64 bytes
eccpos.

/flash_eraseall -j /dev/mtd4
./flash_eraseall: /dev/mtd4: unable to get NAND oobinfo

./nandwrite -j /dev/mtd2 /jffs2.img
MEMSETOOBSEL: Inappropriate ioctl for device

but i think as OneNAND has hw ecc controller so Jffs2 will
not face any problem
still i think mtd should consider for 128 bytes eccpos for
4K page size.

Rgs
Amit

----- Original Message -----
From: "Artem Bityutskiy" <dedekind@infradead.org>
To: "Kyungmin Park" <kmpark@infradead.org>
Cc: "apgmoorthy" <moorthy.apg@samsung.com>;
<linux-mtd@lists.infradead.org>; "Kyungmin Park"
<kyungmin.park@samsung.com>; "lkml"
<linux-kernel@vger.kernel.org>
Sent: Friday, September 26, 2008 10:21 AM
Subject: Re: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD
Driver available.


>
> On Fri, 2008-09-26 at 09:31 +0900, Kyungmin Park wrote:
>> Hi,
>>
>> A few comments
>>
>> >
>> > Signed-off-by: Vishak G <vishak.g@samsung.com>
>> > Signed-off-by: Rohit Hagargundgi <h.rohit@samsung.com>
>>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> > ---
>> > diff -uprN a/drivers/mtd/onenand/onenand_base.c
>> > b/drivers/mtd/onenand/onenand_base.c
>> > --- a/drivers/mtd/onenand/onenand_base.c
>> > 2008-09-16
>> > 20:48:12.000000000 +0530
>> > +++ b/drivers/mtd/onenand/onenand_base.c
>> > 2008-09-24
>> > 17:51:34.000000000 +0530
>> > @@ -9,6 +9,10 @@
>> > * auto-placement support, read-while load support,
>> > various fixes
>> > * Copyright (C) Nokia Corporation, 2007
>> > *
>> > + * Vishak G <vishak.g@samsung.com>, Rohit
>> > Hagargundgi
>> > <h.rohit@samsung.com>
>> > + * Flex-OneNAND support
>> > + * Copyright (C) Samsung Electronics, 2008
>> > + *
>> > * This program is free software; you can redistribute
>> > it and/or modify
>> > * it under the terms of the GNU General Public License
>> > version 2 as
>> > * published by the Free Software Foundation.
>> > @@ -27,6 +31,37 @@
>> >
>> > #include <asm/io.h>
>> >
>> > +const static int boundary[] = {
>> > + FLEXONENAND_DIE0_BOUNDARY,
>> > + FLEXONENAND_DIE1_BOUNDARY,
>> > +};
>> > +
>> > +const static int lock[] = {
>> > + FLEXONENAND_DIE0_ISLOCKED,
>> > + FLEXONENAND_DIE1_ISLOCKED,
>> > +};
>> > +
>>
>> static const as others.
>>
>>
>> > diff -uprN a/include/mtd/mtd-abi.h
>> > b/include/mtd/mtd-abi.h
>> > --- a/include/mtd/mtd-abi.h 2008-09-16
>> > 20:48:12.000000000 +0530
>> > +++ b/include/mtd/mtd-abi.h 2008-09-24
>> > 14:09:06.000000000 +0530
>> > @@ -102,7 +102,11 @@ struct nand_oobinfo {
>> > uint32_t useecc;
>> > uint32_t eccbytes;
>> > uint32_t oobfree[8][2];
>> > +#ifdef CONFIG_MTD_ONENAND
>> > + uint32_t eccpos[128];
>> > +#else
>> > uint32_t eccpos[32];
>> > +#endif
>> > };
>> >
>> > struct nand_oobfree {
>> > @@ -117,7 +121,11 @@ struct nand_oobfree {
>> > */
>> > struct nand_ecclayout {
>> > uint32_t eccbytes;
>> > +#ifdef CONFIG_MTD_ONENAND
>> > + uint32_t eccpos[128];
>> > +#else
>> > uint32_t eccpos[64];
>> > +#endif
>> > uint32_t oobavail;
>> > struct nand_oobfree
>> > oobfree[MTD_MAX_OOBFREE_ENTRIES];
>> > };
>
> I do not think stuff like this is going to be accepted
> because you
> change ABI. You should instead introduce new ioctls or add
> sysfs
> support and expose this information via sysfs. This is
> much bigger
> work, but it is needed.
>
> --
> Best regards,
> Artem Bityutskiy (???????? ?????)
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>




\
 
 \ /
  Last update: 2008-09-26 10:11    [W:0.062 / U:0.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site