lkml.org 
[lkml]   [2008]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] Unified trace buffer

On Fri, 26 Sep 2008, Linus Torvalds wrote:

>
>
> On Fri, 26 Sep 2008, Arnaldo Carvalho de Melo wrote:
> >
> > Why do you need __packed__ here? With or without it the layout is the

From just being paranoid.

> > same:
>
> Indeed. And on some architectures 'packed' will actually mean that the
> compiler may think that it's unaligned, and then generate much worse code
> to access the fields. So if you align things anyway (and you do), then
> 'packed' is the wrong thing to do.

OK, I'm making v6 now with various cleanups. I'll nuke it on that one.

-- Steve



\
 
 \ /
  Last update: 2008-09-26 19:49    [W:0.151 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site