lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: add mmio xi driver
On Thu, Sep 25, 2008 at 06:20:55PM -0700, Randy Dunlap wrote:
> On Thu, 25 Sep 2008 16:22:37 -0700 Greg KH wrote:
>
> >
> > From: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > This patch adds the Mimio Xi interactive whiteboard driver to the tree.
> >
> > It was originally written by mwilder@cs.nmsu.edu, but cleaned up and
> > forward ported by me to the latest kernel version.
> >
> >
> > Cc: Phil Hannent <phil@hannent.co.uk>
> > Cc: <mwilder@cs.nmsu.edu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > ---
> > drivers/input/misc/Kconfig | 11
> > drivers/input/misc/Makefile | 1
> > drivers/input/misc/mimio.c | 913 ++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 925 insertions(+)
> >
> > --- a/drivers/input/misc/Kconfig
> > +++ b/drivers/input/misc/Kconfig
> > @@ -164,6 +164,17 @@ config INPUT_POWERMATE
> > To compile this driver as a module, choose M here: the
> > module will be called powermate.
> >
> > +config INPUT_MIMIO
> > + tristate "Mimio Xi interactive whiteboard support"
> > + depends on USB_ARCH_HAS_HCD
> > + select USB
>
> Prefer not to select entire subsystems, but to depend on them.
> However, lots of drivers in drivers/input/ select USB... :(

When in Rome... :)

> > +static void mimio_irq_out(struct urb *urb)
> > +{
> > + unsigned long flags;
> > + struct mimio *mimio;
> > +
> > + mimio = urb->context;
> > +
> > + if (urb->status)
> > + dev_dbg(&mimio->idev->dev, "urb-status: %d.\n", urb->status);
> > +
> > + spin_lock_irqsave(&mimio->txlock, flags);
> > + mimio->txflags |= MIMIO_TXDONE;
> > + spin_unlock_irqrestore(&mimio->txlock, flags);
> > + wmb();
>
> We want comments/explanation on all barriers or just "barrier();" ??

Ick, good catch, that shouldn't be needed, I'll go delete it.

> > + /*
> > + * Build input device info
> > + */
> > + usb_make_path(udev, path, 64);
>
> s/64/sizeof(path)/

Thanks, will fix.

Thanks for the review, I appreciate it.

greg k-h


\
 
 \ /
  Last update: 2008-09-26 05:23    [from the cache]
©2003-2011 Jasper Spaans