Messages in this thread | | | Date | Thu, 25 Sep 2008 16:55:17 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] net: remove LLTX in atl2 driver |
| |
Chris Snook wrote: > Kevin Hao wrote: >> When NETIF_F_LLTX is set, the atlx driver will use a private lock. >> But in recent kernels this implementation seems redundant and >> can cause problems where AF_PACKET sees things twice. Since >> NETIF_F_LLTX is marked as deprecated and shouldn't be used in >> new driver, this patch removes NETIF_F_LLTX and adds a mmiowb >> before sending packet. >> >> Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > > Can you explain a bit more concretely the problem this solves, and your > testing? Ultimately we'll want to merge this code with the atl1 code, > so we need to be confident that we can and should make the same change > there. > > -- Chris > >> --- >> drivers/net/atlx/atl2.c | 24 +----------------------- >> drivers/net/atlx/atl2.h | 1 - >> 2 files changed, 1 insertions(+), 24 deletions(-)
Not directly addressing your question, but LLTX is indeed deprecated and in general we want to move away from it.
Jeff
| |