lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/3] Unified trace buffer


On Thu, 25 Sep 2008, Linus Torvalds wrote:
>
> You also ignore the early trace issues, and have apparently not used it
> for FTRACE. You also ignore the fact that without TSC, it goes into the
> same "crap mode" that is appropriate for the scheduler, but totally
> useless for tracing.

Oh, and I didn't notice (because Steven pointed out "notrace" and I didn't
see any of them), that in order to get things to work you had just added

CFLAGS_REMOVE_lockdep.o = -pg
CFLAGS_REMOVE_lockdep_proc.o = -pg
CFLAGS_REMOVE_mutex-debug.o = -pg
CFLAGS_REMOVE_rtmutex-debug.o = -pg
CFLAGS_REMOVE_cgroup-debug.o = -pg
CFLAGS_REMOVE_sched_clock.o = -pg
CFLAGS_REMOVE_sched.o = -mno-spe -pg

all ovr the place, which was part of my argument against this crap in the
first place.

Yes, by using all that common infrastructure, you can share some code, but
you will always hit that case that now you have serious issues with
actually marking it. Now the tracer has to have recursion detection if you
ever want to trace any function that might be used for the clock - and
quite frankly, especially with virtualization, it's not AT ALL obvious
what those are all the time..

That is exactly one of the examples I gave for _not_ doing this. Go back
and read my previous emails. Rather than talking about how I call your
arguments BS without saying why.

Linus


\
 
 \ /
  Last update: 2008-09-25 22:39    [from the cache]
©2003-2011 Jasper Spaans