lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] oprofile: Don't report Nehalem as core_2
    On 20.08.08 18:40:32, Andi Kleen wrote:
    > From: Andi Kleen <ak@linux.intel.com>
    >
    > This essentially reverts Linus' earlier 4b9f12a3779c548b68bc9af7d94030868ad3aa1b
    > commit. Nehalem is not core_2, so it shouldn't be reported as such.
    > However with the earlier arch perfmon patch it will fall back to
    > arch perfmon mode now, so there is no need to fake it as core_2.
    > The only drawback is that Linus will need to patch the arch perfmon
    > support into his oprofile binary now, but I think he can do that.
    >
    > Signed-off-by: Andi Kleen <ak@linux.intel.com>

    I will send this patch upstream together with the architectural
    perfmon implementation and when the userland part is upstream.

    -Robert

    > ---
    > arch/x86/oprofile/nmi_int.c | 3 ---
    > 1 files changed, 0 insertions(+), 3 deletions(-)
    >
    > diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
    > index 6438c32..669a713 100644
    > --- a/arch/x86/oprofile/nmi_int.c
    > +++ b/arch/x86/oprofile/nmi_int.c
    > @@ -418,9 +418,6 @@ static int __init ppro_init(char **cpu_type)
    > case 15: case 23:
    > *cpu_type = "i386/core_2";
    > break;
    > - case 26:
    > - *cpu_type = "i386/core_2";
    > - break;
    > default:
    > /* Unknown */
    > return 0;
    > --
    > 1.5.6
    >
    >

    --
    Advanced Micro Devices, Inc.
    Operating System Research Center
    email: robert.richter@amd.com



    \
     
     \ /
      Last update: 2008-09-25 22:07    [W:6.317 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site