lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patches in this message
    /
    SubjectRE: [PATCH 1/6] bfa: Brocade BFA FC SCSI Driver submission
    Date
    From
    Thanks James and Greg for the quick check on the patches.

    I check the original patch, it is correct. I need to check the outlook
    setting to see how to prevent this issue.

    This is my first time sending a patch, is there any trick to prevent
    line-wrap? I did send it using plain text and I tried to send to myself
    before sending to lkml, and I did't see this problem.

    Sorry about the trouble.

    Jing

    -----Original Message-----
    From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
    Sent: Wednesday, September 24, 2008 10:14 PM
    To: Greg KH
    Cc: Jing Huang; linux-scsi@vger.kernel.org;
    linux-kernel@vger.kernel.org; Ramkumar Vadivelu; Vinodh Ravindran;
    Srikanth Rayas (CW)
    Subject: Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI Driver submission

    On Wed, 2008-09-24 at 21:49 -0700, Greg KH wrote:
    > On Wed, Sep 24, 2008 at 08:56:14PM -0700, Jing Huang wrote:
    > > --- orig/drivers/scsi/bfa/bfad_attr.c 1969-12-31
    16:00:00.000000000
    > > -0800
    > > +++ patch/drivers/scsi/bfa/bfad_attr.c 2008-09-24
    12:08:23.000000000
    > > -0700
    > > @@ -0,0 +1,660 @@
    > > +/*
    > > + * Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
    > > + * All rights reserved
    > > + * www.brocade.com
    > > + *
    > > + * Linux driver for Brocade Fibre Channel Host Bus Adapter.
    > > + *
    > > + * This program is free software; you can redistribute it and/or
    modify
    > > it
    > Your patch is line-wrapped and can't be applied :(

    Actually, it's more than just linewrapping. The patch to the Makefile
    looks to be actively mangled:

    +++ patch/drivers/scsi/bfa/Makefile 2008-09-24 12:08:24.000000000
    -0700
    @@ -0,0 +1,25 @@
    +#
    +# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
    +# All rights reserved
    +# www.brocade.com
    +#
    +# Linux driver for Brocade Fibre Channel Host Bus Adapter.
    +#
    +# This program is free software; you can redistribute it and/or modify
    +it # under the terms of the GNU General Public License (GPL) Version 2
    +as # published by the Free Software Foundation # # This program is
    +distributed in the hope that it will be useful, but # WITHOUT ANY
    +WARRANTY; without even the implied warranty of # MERCHANTABILITY or
    +FITNESS FOR A PARTICULAR PURPOSE. See the GNU # General Public License
    The # beginning the line got wrapped here before the patch was made.

    James




    \
     
     \ /
      Last update: 2008-09-25 07:37    [W:0.061 / U:30.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site