lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/39] KVM: Handle spurious acks for PIT interrupts
    Date
    From: Avi Kivity <avi@qumranet.com>

    Spurious acks can be generated, for example if the PIC is being reset.
    Handle those acks gracefully rather than flooding the log with warnings.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    arch/x86/kvm/i8254.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
    index 7d04dd3..c842060 100644
    --- a/arch/x86/kvm/i8254.c
    +++ b/arch/x86/kvm/i8254.c
    @@ -228,7 +228,7 @@ void kvm_pit_ack_irq(struct kvm_irq_ack_notifier *kian)
    irq_ack_notifier);
    spin_lock(&ps->inject_lock);
    if (atomic_dec_return(&ps->pit_timer.pending) < 0)
    - WARN_ON(1);
    + atomic_inc(&ps->pit_timer.pending);
    ps->irq_ack = 1;
    spin_unlock(&ps->inject_lock);
    }
    --
    1.6.0.1


    \
     
     \ /
      Last update: 2008-09-25 14:01    [W:4.177 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site