lkml.org 
[lkml]   [2008]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] remove fullflush and nofullflush in IOMMU generic option
    From
    On Mon, 22 Sep 2008 20:34:14 +0200
    Joerg Roedel <joerg.roedel@amd.com> wrote:

    > On Tue, Sep 23, 2008 at 01:51:05AM +0900, FUJITA Tomonori wrote:
    > > The patch that I sent doesn't make any changes for you. GART works as
    > > before and AMD IOMMU takes a new parameter, fullflush, as you want. It
    > > does the exact same thing that the first version of your patchset for
    > > 2.6.28.
    > >
    > > So please let me apply it then we can stop this discussion.
    >
    > Ok, so it was not nice from me to let Ingo pull this patch without your
    > ack, I already admitted.

    I didn't ask you to try to get my ACK before pushing the patches that
    affect all the IOMMUs. I'll never ask for such.

    I asked you to get the ACKs from the IOMMUs maintainers that your
    patches affect.

    If the IOMMUs maintainers who your patch affects agree on your patch,
    I will not be against it even if I don't like it.

    This time, you tried to add a generic parameter that would be useful
    for VT-d, but seems that the VT-d maintainer is not ready for such
    decision. Thus, I think that postponing adding the parameter was a
    reasonable decision for everyone.

    I also insisted that we need serious consideration about how all the
    generic parameters interact with each other before changing them, but
    again, if all the IOMMUs maintainers agree on a different plan, it's
    fine by me.


    > To end this discussion and get to productive
    > discussions, Ingo, please apply this patch. I hope we will work together
    > on a final solution for the problem.

    Thanks very much.


    \
     
     \ /
      Last update: 2008-09-24 15:15    [W:0.019 / U:62.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site