Messages in this thread | | | Date | Tue, 23 Sep 2008 10:39:15 +0200 | From | Wim Van Sebroeck <> | Subject | Re: [PATCH 1/3] watchdog: sync linux-omap changes |
| |
Hi Russell,
> It's unused, but it's a minor point, something that shouldn't stand > in the way of it going into the watchdog tree. It doesn't cause a > build error and doesn't cause malfunction. It's just a little untidy > and can be addressed separately.
We will need to address it later then. I just added the patches to the linux-2.6-watchdog-mm tree.
> + omap_wdt_set_timeout(wdev); > + omap_wdt_enable(wdev); > spin_unlock(&wdt_lock); > + > + omap_wdt_ping(wdev); > > which is moving omap_wdt_ping() outside of the spin lock, which I > doubt actually causes any problem in real life on OMAP platforms. > Granted that theoretically and logically it's wrong.
And since this is indeed wrong, I changed this back.
Kind regards, Wim.
| |