[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module
On Mon, Sep 22, 2008 at 1:59 PM, Timur Tabi <> wrote:
> Dan Williams wrote:
>> The last three hunks should be broken out into a separate 'fix' patch
>> with its own changelog.
> Can you be more specific? I can see how "return 0" -> "return -ENOMEM" could be
> separated out, but the Kconfig hunk is integral to the patch, and the "if
> (fsl_chan->desc_pool) return 1;" is needed to prevent a memory leak if the
> module is unloaded.

Sorry, I miscounted. I was indeed referring to the just the "return 0
--> return -ENOMEM" fix.


 \ /
  Last update: 2008-09-23 22:51    [W:0.043 / U:3.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site