Messages in this thread | | | Date | Mon, 22 Sep 2008 04:39:46 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH] mm: do_generic_file_read() never gets a NULL 'filp' argument |
| |
On Mon, Sep 22, 2008 at 01:33:38AM -0700, Andrew Morton wrote: > On Mon, 22 Sep 2008 11:46:10 +0530 Krishna Kumar <krkumar2@in.ibm.com> wrote: > > > From: Krishna Kumar <krkumar2@in.ibm.com> > > > > The 'filp' argument to do_generic_file_read() is never NULL. > > > > How did you verify this? > > NFS used to like passing NULL file*'s into VFS functions. I don't > recall whether it affected do_generic_file_read().
The only thing nfsd passed a NULL file pointer in is ->fsync on directories. If anyone did pass a NULL file pointer into do_generic_file_read it would oops in it's very first line of code.
| |