lkml.org 
[lkml]   [2008]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pcmcia: Fix broken abuse of dev->driver_data
> > +	
>
> trailing whitespace

Nod..

> > if (did && (did->match_flags & PCMCIA_DEV_ID_MATCH_DEVICE_NO) &&
> > (p_dev->socket->device_count == 1) && (p_dev->device_no ==
> > 0)) pcmcia_add_device_later(p_dev->socket, 0);
>
> uh?

Looks like a mailer folded it later, but the patch itself seems just fine.

> >
> > - put_module:
> > +put_module:
> > if (ret)
> > module_put(p_drv->owner);
> > - put_dev:
> > +put_dev:
>
> unrelated -- please do not change it this time.

Not sure you can have it both ways - if you don't want stray whitespace
then fixing the labels to conform to coding style seems to go with it ;)

Alan


\
 
 \ /
  Last update: 2008-09-23 00:15    [W:0.097 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site