Messages in this thread | | | Date | Sat, 20 Sep 2008 13:14:42 -0700 | From | Greg KH <> | Subject | Re: [PATCH] debug: Introduce a dev_WARN() function |
| |
On Sat, Sep 20, 2008 at 11:11:13AM -0700, Arjan van de Ven wrote: > On Fri, 19 Sep 2008 21:26:30 -0700 > Greg KH <greg@kroah.com> wrote: > > > On Fri, Sep 19, 2008 at 09:07:33PM -0700, Arjan van de Ven wrote: > > > > > > From: Arjan van de Ven <arjan@linux.intel.com> > > > Date: Fri, 19 Sep 2008 21:03:06 -0700 > > > Subject: [PATCH] debug: Introduce a dev_WARN() function > > > > > > in the line of dev_printk(), this patch introduces a dev_WARN() > > > macro, that takes a struct device and then a printk format/args set > > > of arguments. Unlike dev_printk(), the effect is that of WARN() in > > > that a full warning message (including filename/line, module list, > > > versions and a backtrace) is printed in addition to the device name > > > and the arguments. > > > > I like the idea, but we already have dev_warn(), so dev_WARN() might > > be a bit confusing for people. > > > > Perhaps just documenting it with a docbook tag would suffice? > > > > I added a set of comments, and also ended up doing the below USB change
Ok, that looks good, care to resend all of these, with the changed original one so that I can apply them?
thanks,
greg k-h
| |