Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver | Date | Tue, 2 Sep 2008 14:01:24 +0200 |
| |
On Tuesday 02 September 2008, Li Yang wrote: > Some of Freescale SoC chips have a QE or CPM co-processor which > supports full speed USB. The driver adds device mode support > of both QE and CPM USB controller to Linux USB gadget. The > driver is tested with MPC8360 and MPC8272, and should work with > other models having QE/CPM given minor tweaks. > > Signed-off-by: Xie Xiaobo <X.Xie@freescale.com> > Signed-off-by: Li Yang <leoli@freescale.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
All my previous review comments have been addressed.
> + udc_controller->soc_type = (unsigned long)np->data;
I'm not sure about this line, shouldn't that be udc_controller->soc_type = (unsigned long)match->data; ?
Arnd <><
| |