lkml.org 
[lkml]   [2008]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, resend] x86: x86_{phys,virt}_bits field also for i386
Jan Beulich wrote:
> Make the x86_{phys,virt}_bits common for 32- and 64-bits, and use the
> former in ioremap's phys_addr_valid() check also on 32bit/PAE.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> c->x86_cache_alignment = 32;
> c->x86_clflush_size = 32;
> +#ifdef CONFIG_X86_PAE
> + c->x86_phys_bits = 36;
> +#else
> + c->x86_phys_bits = 32;
> +#endif
> + c->x86_virt_bits = 32;
>

This is logical but wrong. This is supposed to be about the CPU, not
about the kernel.

That would mean using the physbit information if it is present,
otherwise (pae_feature_bit ? 36 : 32).

-hpa


\
 
 \ /
  Last update: 2008-09-03 00:15    [W:0.134 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site