Messages in this thread | | | Date | Sat, 20 Sep 2008 00:09:46 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] remove fullflush and nofullflush in IOMMU generic option |
| |
On Sat, Sep 20, 2008 at 06:56:21AM +0900, FUJITA Tomonori wrote: > > Because you did things int the wrong way, I said again and again. > > I can't see why you refuse to do the things in the proper way. > > > > objections agains the generic iommu=fullflush come up. The patch does > > not break anything and just moves the iommu=flush parameter (which is > > already available) to pci-dma.c to make it useable by AMD IOMMU too. > > Breaking anything does mean that it's fine. My patch doesn't break > anything too. > > I'm not against fullflush (as I said again and again). I guess that > it's the right move though it might be not so useful if VT-d doesn't > support it. > > I'm against totally pointless nofullflush and the way you changed the > generic IOMMU code.
Then submit a patch that changes it to the version you prefer. I already said that I am fine with the removal of nofullflush. But completly reverting is the wrong way. For AMD IOMMU I want to use the iommu=fullflush way because I want to reuse a parameter thats already there. Thats why I am against your reverting patch. So now I stop repeating my points again and again. EOD.
Joerg
-- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
| |