lkml.org 
[lkml]   [2008]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -tip FIXED] ftrace: add nop tracer
    On Fri, 19 Sep 2008 03:06:43 -0700
    Steven Noonan <steven@uplinklabs.net> wrote:

    > --- a/kernel/trace/trace.h
    > +++ b/kernel/trace/trace.h
    > @@ -339,6 +339,10 @@ extern int trace_selftest_startup_preemptirqsoff(struct tracer *trace,
    > extern int trace_selftest_startup_wakeup(struct tracer *trace,
    > struct trace_array *tr);
    > #endif
    > +#ifdef CONFIG_NOP_TRACER
    > +extern int trace_selftest_startup_nop(struct tracer *trace,
    > + struct trace_array *tr);
    > +#endif
    > #ifdef CONFIG_CONTEXT_SWITCH_TRACER
    > extern int trace_selftest_startup_sched_switch(struct tracer *trace,
    > struct trace_array *tr);

    Consider omitting the ifdefs around the declarations.

    pro: the code looks nicer and is less likely to suffer build errors
    with weird config combinations.

    con: build errors are reported at link-time rather than at compile-time.

    Personally, I think pro>con here.


    \
     
     \ /
      Last update: 2008-09-19 23:27    [W:3.751 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site