lkml.org 
[lkml]   [2008]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] ext2: Avoid printk floods in the face of directory corruption
On Sat, Sep 13, 2008 at 11:32 PM, Theodore Ts'o <tytso@mit.edu> wrote:
[...]
> Eend:
> - p = (ext2_dirent *)(kaddr + offs);
> - ext2_error (sb, "ext2_check_page",
> - "entry in directory #%lu spans the page boundary"
> - "offset=%lu, inode=%lu",
> - dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs,
> - (unsigned long) le32_to_cpu(p->inode));
> + if (!quiet) {
> + p = (ext2_dirent *)(kaddr + offs);
> + ext2_error (sb, "ext2_check_page",
^^^^^^^^^^^^^^^^^^
> + "entry in directory #%lu spans the page boundary"
> + "offset=%lu, inode=%lu",
> + dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs,
> + (unsigned long) le32_to_cpu(p->inode));

Minor issue. Since you are already changing "ext2_check_page" to
__func__, you might as well change it here too.

Thanks, Eugene


\
 
 \ /
  Last update: 2008-09-18 11:49    [W:0.077 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site