Messages in this thread | | | Date | Thu, 18 Sep 2008 17:48:21 +0200 | From | Haavard Skinnemoen <> | Subject | Re: [PATCH] dmatest: properly handle duplicate DMA channels |
| |
Timur Tabi <timur@freescale.com> wrote: > Haavard Skinnemoen wrote: > > > ...though I don't really see why you have to use > > list_for_entry_safe()... > > You use it in dmatest_remove_channel(), so I figured I'd do the same thing.
dmatest_remove_channel() may call list_del() on the current entry, so it has to. As long as you're not altering the list, the _safe() variant shouldn't be necessary.
Haavard
| |