Messages in this thread | | | Date | Thu, 18 Sep 2008 14:29:22 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3) |
| |
* Jan Beulich <jbeulich@novell.com> wrote:
> >>> Ingo Molnar <mingo@elte.hu> 18.09.08 13:20 >>> > > > >* Ingo Molnar <mingo@elte.hu> wrote: > > > >> * Jan Beulich <jbeulich@novell.com> wrote: > >> > >> > I'm really sorry for that, yet another merge oversight (not caught > >> > because only re-tested on x86-64). Here's a better one. > >> > >> ah, i see, the delta below. Nasty. > > > >the attached config fails in a similar way. > > Hmm, yes, other than in .27, -tip derives resource_size_t from phys_addr_t, > regardless of CONFIG_RESOURCES_64BIT (and the config you provided > is a non-PAE one). I have to question that change, which I'm sure is > responsible for this failure. If there's a good reason for this, then > phys_addr_valid() should use phys_addr_t as its parameter type (and > so should ioremap() & Co), and the pre-processor conditional should > then change to depend on CONFIG_PHYS_ADDR_T_64BIT. Since ioremap() > would need to change first, I'd have to withdraw the patch until that > gets sorted out.
(Cc:-ing Jeremy and Hugh).
Ingo
| |