Messages in this thread | | | Date | Wed, 17 Sep 2008 16:03:01 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 3/6] pci: using printk(KERN_PCI v3 |
| |
On Wed, Sep 17, 2008 at 3:28 PM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote: > On Wednesday 17 September 2008 02:27:44 am Yinghai Lu wrote: >> v2: use printk(KERN_DEBUG KERN_PCI ... >> v3: fix checkpatch error and warning >> >> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> >> >> --- >> drivers/pci/probe.c | 28 +++++++++++++++++----------- >> 1 file changed, 17 insertions(+), 11 deletions(-) >> >> Index: linux-2.6/drivers/pci/probe.c >> =================================================================== >> --- linux-2.6.orig/drivers/pci/probe.c >> +++ linux-2.6/drivers/pci/probe.c >> @@ -304,7 +304,8 @@ static int __pci_read_base(struct pci_de >> } else { >> res->start = l64; >> res->end = l64 + sz64; >> - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", >> + printk(KERN_DEBUG KERN_PCI >> + "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", >> pci_name(dev), pos, res->start, res->end); > > I really don't understand the point of this series. I think > the user experience is too confusing. > > But if you're going to change printks like the one above, > please at least make it use dev_printk() like most of the > rest of the PCI core.
will look at dev_printk...
YH
| |