lkml.org 
[lkml]   [2008]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Populating multiple ptes at fault time
    Jeremy Fitzhardinge wrote:
    >> One problem is the accessed bit. If it's unset, the shadow code
    >> cannot make the pte present (since it has to trap in order to set the
    >> accessed bit); if it's set, we're lying to the vm.
    >>
    >
    > So even if the guest pte were present but non-accessed, the shadow pte
    > would have to be non-present and you'd end up taking the fault anyway?
    >
    >

    Yes.

    > Hm, that does undermine the benefits. Does that mean that when the vm
    > clears the access bit, you always have to make the shadow non-present?
    > I guess so. And similarly with dirty and writable shadow.
    >
    >

    Yes.

    > The counter-argument is that something has gone wrong if we start
    > populating ptes that aren't going to be used in the near future anyway -
    > if they're never used then any effort taken to populate them is wasted.
    > Therefore, setting accessed on them from the outset isn't terribly bad.
    >
    >

    We don't know whether the page will be used or not. Keeping the
    accessed bit clear allows the vm to reclaim it early, and in preference
    to the pages it actually used.

    We could work around it by having a hypercall to read and clear accessed
    bits. If we know the guest will only do that via the hypercall, we can
    keep the accessed (and dirty) bits in the host, and not update them in
    the guest at all. Given good batching, there's potential for a large
    win there.

    (If the host throws away a shadow page, it could sync the bits back into
    the guest pte for safekeeping)

    --
    I have a truly marvellous patch that fixes the bug which this
    signature is too narrow to contain.



    \
     
     \ /
      Last update: 2008-09-18 00:55    [W:0.028 / U:30.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site