lkml.org 
[lkml]   [2008]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v5
On Wed, Sep 17, 2008 at 1:47 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
>> On Wed, Sep 17, 2008 at 12:10:09AM -0700, Yinghai Lu wrote:
>> > KERN_PCI
>> > KERN_ACPI
>> > v4: fix some checkpatch error and warning
>> > v5: add default with DEFINE_LOGLEVE_SETUP_DEF
>> > KERN_APIC
>> >
>> > usage:
>> > in .h to have
>> > #define KERN_PCI "<pci>"
>> > in .c to have
>> > DEFINE_LOGLEVEL_SETUP(pci, KERN_PCI, "pci:");
>> > then could use
>> > printk(KERN_DEBUG KERN_PCI fmt, ...);
>> > and command line
>> > loglevel=3,pci:8
>> >
>> > you can add different printk to different files of one subsys if you like
>> > not just one susbsys one tag, and don't need to update kernel.h to add more tags
>>
>> I think all of this is overdesigned and stupid.
>>
>> People expecting that loglevels are exactly right so they can calm
>> messages are like security-savvy people who expect all security
>> relevant bugfixes carry CVE tag.
>>
>> grep says there are 50757 printk calls, only 32129 of them carry KERN_
>> tag.
>>
>> Oh, and new and improved logs:
>>
>> [ 0.340326] pci 0000:00:01.0: PME# supported from D0 D3hot D3cold
>> [ 0.340326] pci 0000:00:01.0: PME# disabled
>> [ 0.340326] <pci>PCI: 0000:00:1a.0 reg 20 io port: [dc00, dc1f]
>> [ 0.340413] <pci>PCI: 0000:00:1a.1 reg 20 io port: [e000, e01f]
>> [ 0.340549] <pci>PCI: 0000:00:1a.7 reg 10 32bit mmio: [febffc00, febfffff]
>> ^^^^^^^^^

> and it's bad and a showstopper if the default output of 'dmesg'
> degrades, like your noticed - those are bugs in the concept and need to
> be fixed.

v6 should fix the problem, to support several seperate loglevel.

YH


\
 
 \ /
  Last update: 2008-09-17 18:25    [from the cache]
©2003-2011 Jasper Spaans