lkml.org 
[lkml]   [2008]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + itimers-fix-itimer-many-thread-hang.patch added to -mm tree
On 09/15, Frank Mayhar wrote:
>
> I have a few more things to do; expect a new iteration of the patch
> tonight or tomorrow.

Great.

Please also remove tasklist_lock from thread_group_cputime_alloc_smp(),
it is not needed.

I'd also suggest to kill

if (sig->cputime.totals)
return 0;

, the caller has already checked this.


Please note also that thread_group_cputime_clone_thread() doesn't need
the second argument.


Very minor nit, but thread_group_cputime_alloc_smp() doesn't really
need get_cpu() + put_cpu_no_resched(), it can use smp_processor_id().

Oleg.



\
 
 \ /
  Last update: 2008-09-16 13:09    [W:0.057 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site