Messages in this thread | | | Date | Tue, 16 Sep 2008 07:42:16 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip] uaccess: fix parameters inversion for __copy_from_user_inatomic() |
| |
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > The following patch changes to use __copy_from_user_inatomic(), > but the passing parameters incorrect. > > x86: some lock annotations for user copy paths, v3 > > - add annotation back to clear_user() > - change probe_kernel_address() to _inatomic*() method > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > --- > include/linux/uaccess.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h > index 2062293..6b58367 100644 > --- a/include/linux/uaccess.h > +++ b/include/linux/uaccess.h > @@ -78,7 +78,7 @@ static inline unsigned long __copy_from_user_nocache(void *to, > \ > set_fs(KERNEL_DS); \ > pagefault_disable(); \ > - ret = __copy_from_user_inatomic((__force typeof(retval) __user *)(addr), &(retval), sizeof(retval)); \ > + ret = __copy_from_user_inatomic(&(retval), (__force typeof(retval) __user *)(addr), sizeof(retval)); \
*blush*. Thanks!
Ingo
| |