Messages in this thread | | | Date | Tue, 16 Sep 2008 11:53:36 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] introduce boot_printk() |
| |
Yinghai Lu wrote: >> >> Not only do you have duplication, here, but inconsistency... > > how about > pci_printk(v, KERN_DEBUG "...\n"); > > will put > <pci> <7> ...\n > in dmesg bug, > > and let vprintk get rid of <pci> like <7> > > is that what you want? >
First of all, what is the "v" here, and why not just have printk(KERN_PCI KERN_DEBUG "...\n");
... and we can do #define PCI_DEBUG KERN_PCI KERN_DEBUG even.
We do have a need for special macros when we're doing device-specific prefixes, of course. If that is what your "v" is meant to be, then there was an implicit topic shift in the discussion thread.
-hpa
| |