lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] MMC: Use write timeout value as read from CSR
2008/9/15 Pierre Ossman <drzeus-mmc@drzeus.cx>:
> On Mon, 15 Sep 2008 09:03:41 +0100
> "Matt Fleming" <mattjfleming@googlemail.com> wrote:
>
>> Yeah it does, but the card pointer isn't copied to host->card. That
>> was the point I was trying to make above.
>
> I understood that, but you shouldn't be using host->card to begin with.
> Host drivers shouldn't be concerned with card specifics at all as the
> logic can sometimes be quite complex. All information the host drivers
> need should be in the request structure. If it isn't, then we need to
> fix the request structure, not change the drivers to start poking
> deeper into the MMC stack.
>

OK, I can see your point here. However, this is a completely different
change to my original patch. Would it not make more sense to queue my
original patch and then for me to write some patches to move all the
timeout info into the request structure?

> Looking further at the specs, this needs to be handled int the caller
> (i.e. mmc_send_cid() and mmc_send_csd()). The specs specify the
> timeouts used for those commands and they are actually different from
> the timeouts used elsewhere. IOW this could not be properly handled in
> some generic helper.
>

Again, this is a good idea but a different change to the patch I wrote
originally.

So, what I propose is this. Could you please queue my bug fix (I can
send the two patches again) and then I will begin working on the
generic patches to fix the issues that you've raised in this thread?
How does that sound?


\
 
 \ /
  Last update: 2008-09-15 11:27    [W:0.087 / U:1.800 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site