lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] net driver fixes
On Mon, Sep 15, 2008 at 02:11:59PM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 15 Sep 2008 13:27:16 -0700 (PDT)
>
> > I'll take another look at the queue and try to give you some
> > more specific feedback.
>
> Thomas Bogendoerfer (1):
> tulip: Fix dead 21041 ethernet after ifconfig down
>
> Not a regression, that problem has been there forever.

> Hannes Hering (1):
> ehea: Fix DLPAR memory handling
>
> No kernel bugzilla, no regression list entry, no way.
>
> Krzysztof Halasa (1):
> wan/hdlc_x25.c: fix a NULL dereference
>
> Not a 2.6.27 regression, this problem has been there forever.

> So, as I said, the vast majority of this stuff is absolulte not
> appropriate. Most of it can totally wait for 2.6.28, and not
> be merged now.
>
> You can accelerate this process by making sure that every
> commit message has a reference to the regression list entry
> or a kernel bugzilla that the patch fixes.

So, my takeaway from this is...

1) Creating a bugzilla entry magically makes a bug fix acceptable?

2) We no longer want "this kills the driver" fixes?

I disagree with that logic, and I seriously doubt Linus wants to turn
away serious fixes to serious problems. Many of these are clearly
needed, just read the extended patch description and the patch itself.

You just rejected patches that (a) fixed dead ethernet [de2104x], (b) fixed an
oops [WAN], and (c) fixed memory corruption [ehea].

I feel like I have just stepped into Odd World, if you don't want fixes
as serious as these.

Jeff





\
 
 \ /
  Last update: 2008-09-15 23:27    [W:0.080 / U:17.400 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site