lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: wdt285: fix sparse warnings
Ben,

...
> @@ -141,13 +141,13 @@ static long watchdog_ioctl(struct file *
> switch (cmd) {
> case WDIOC_GETSUPPORT:
> ret = 0;
> - if (copy_to_user((void *)arg, &ident, sizeof(ident)))
> + if (copy_to_user((void __user *)arg, &ident, sizeof(ident)))
> ret = -EFAULT;
> break;
>
...

Isn't it better to fix this like we did with the other watchdog drivers:
void __user *argp = (void __user *)arg;
int __user *p = argp;
...
if (copy_to_user(argp, &ident, sizeof(ident)))
...

Regards,
Wim.



\
 
 \ /
  Last update: 2008-09-15 10:09    [W:0.029 / U:37.024 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site