lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v5][PATCH 2/8] General infrastructure for checkpoint restart
From
Date
On Sat, 2008-09-13 at 19:06 -0400, Oren Laadan wrote:
>
> +void *cr_hbuf_get(struct cr_ctx *ctx, int n)
> +{
> + void *ptr;
> +
> + BUG_ON(ctx->hpos + n > CR_HBUF_TOTAL);
> + ptr = (void *) (((char *) ctx->hbuf) + ctx->hpos);
> + ctx->hpos += n;
> + return ptr;
> +}

All of the casting here is unnecessary. 'void *' behaves like 'char *'
when you do arithmetic on it.

I really do detest having a memory allocator BUG_ON() when it runs out
of space.

-- Dave



\
 
 \ /
  Last update: 2008-09-15 20:05    [W:0.242 / U:65.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site