lkml.org 
[lkml]   [2008]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] e100: Use pci_pme_active to clear PME_Status and disable PME#
Date
On Saturday, 13 of September 2008, Jeff Garzik wrote:
> Rafael J. Wysocki wrote:
> > e100: Use pci_pme_active to clear PME_Status and disable PME#
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > ---
> > drivers/net/e100.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Index: linux-2.6/drivers/net/e100.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/net/e100.c
> > +++ linux-2.6/drivers/net/e100.c
> > @@ -2738,9 +2738,7 @@ static int __devinit e100_probe(struct p
> > nic->flags |= wol_magic;
> >
> > /* ack any pending wake events, disable PME */
> > - err = pci_enable_wake(pdev, 0, 0);
> > - if (err)
> > - DPRINTK(PROBE, ERR, "Error clearing wake event\n");
> > + pci_pme_active(pdev, false);
>
> Since I am rusty on my PCI... why is this needed?

Because we just want to clear PME_Status and disable PME#, but
pci_enable_wake() involves an ACPI call and generally depends on the
dev->power.can_wakeup and dev->power.should_wakeup flags being set.

The patch I sent here http://marc.info/?l=linux-kernel&m=122096638020191&w=4
has a better changelog.

Thanks,
Rafael


\
 
 \ /
  Last update: 2008-09-15 01:43    [W:0.282 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site