Messages in this thread | | | Subject | Re: [PATCH] xen: Fix for xen guest with mem > 3.7G | From | Roberto De Ioris <> | Date | Sun, 14 Sep 2008 23:43:13 +0200 |
| |
On Sun, 2008-09-14 at 07:42 -0700, Jeremy Fitzhardinge wrote: > PFN_PHYS() can truncate large addresses unless its passed a suitable > large type. This is fixed more generally in the patch series > introducing phys_addr_t, but we need a short-term fix to solve a > regression. > > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > Cc: roberto@unbit.it > --- > arch/x86/xen/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > =================================================================== > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -42,7 +42,7 @@ > > e820.nr_map = 0; > > - e820_add_region(0, PFN_PHYS(max_pfn), E820_RAM); > + e820_add_region(0, PFN_PHYS((u64)max_pfn), E820_RAM); > > /* > * Even though this is normal, usable memory under Xen, reserve
In this way you pass a 64bit integer to the function, but max_pfn in origin is still 32bit.
max_pfn need to be 64bit to supporto more than 4GB
> > -- Roberto De Ioris http://unbit.it JID: roberto@jabber.unbit.it
| |