lkml.org 
[lkml]   [2008]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [update3] [PATCH] init: bzip2 or lzma -compressed kernels and initrds
Alain Knaff wrote:
>> There is no reason to include header files conditionally.
>>
>> It might be worthwhile to create a proper subdirectory rather than using
>> an underscored namespace (also, in general, dashes are preferred in
>> filenames.)
>
> I hate to contradict you, but in that case, lots of other filenames
> would need fixing too:

Not arguing that. However, in this case I think the right thing is to
make a subdirectory.

>> Any reason to not just use <linux/compiler.h> here?
>
> As you may have understood, the decompressors themselves are samples
> and/or reference implementations downloaded from elsewhere, and thus
> might not be up to the coding standards of the rest of the kernel.

I'm familiar with that. However, I think in this case it is preferrable
to use the all-kernel facilities, since there is an obvious direct mapping.

-hpa


\
 
 \ /
  Last update: 2008-09-12 01:25    [W:0.108 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site