lkml.org 
[lkml]   [2008]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH, RFC, tip/core/rcu] v3 scalable classic RCU implementation
    From
    Date
    "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> writes:
    >
    > -#if defined(CONFIG_PREEMPT_RCU) && defined(CONFIG_NO_HZ)
    > +#if defined(CONFIG_NO_HZ)
    > extern void rcu_irq_enter(void);
    > extern void rcu_irq_exit(void);
    > #else
    > # define rcu_irq_enter() do { } while (0)
    > # define rcu_irq_exit() do { } while (0)
    > -#endif /* CONFIG_PREEMPT_RCU */
    > +#endif /* #if defined(CONFIG_NO_HZ) */

    It would be better if you hung rcu_irq_enter in the irq_enter() if
    statement that checks if the task was idle or not. This way it would
    be zero overhead for interruptions of non busy CPUs, keeping
    it out of many fast paths.

    Haven't read everything, sorry.

    -Andi


    \
     
     \ /
      Last update: 2008-09-01 11:41    [W:0.020 / U:39.072 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site