Messages in this thread | | | Subject | Re: Misc fixes for 2.6.27 | From | Andi Kleen <> | Date | Tue, 02 Sep 2008 00:32:16 +0200 |
| |
David Woodhouse <dwmw2@infradead.org> writes: > + > +static struct dmi_system_id __initdata intel_iommu_dmi_table[] = { > + { /* Some DG33BU BIOS revisions advertised non-existent VT-d */
Are you sure it's non existent? A G33 chipset should have it in hardware I thought.
I'm not sure this is really the right way to handle this anyways. If there's ever a working BIOS it will be blacklisted too. And normally BIOS bugs don't come in one board alone, but in a range of them and then adding more and more identifiers is quite painful.
Better would be to add some generic sanity checks that catches the issues these BIOS revisions are having.
> + .callback = blacklist_iommu, > + .ident = "Intel DG33BU", > + { DMI_MATCH(DMI_BOARD_VENDOR, "Intel Corporation"), > + DMI_MATCH(DMI_BOARD_NAME, "DG33BU"), > + } > + },
-Andi
-- ak@linux.intel.com
| |