lkml.org 
[lkml]   [2008]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Misc fixes for 2.6.27
From
Date
David Woodhouse <dwmw2@infradead.org> writes:
> +
> +static struct dmi_system_id __initdata intel_iommu_dmi_table[] = {
> + { /* Some DG33BU BIOS revisions advertised non-existent VT-d */

Are you sure it's non existent? A G33 chipset should have it in
hardware I thought.

I'm not sure this is really the right way to handle this anyways.
If there's ever a working BIOS it will be blacklisted too. And
normally BIOS bugs don't come in one board alone, but in a range
of them and then adding more and more identifiers is quite painful.

Better would be to add some generic sanity checks that catches
the issues these BIOS revisions are having.

> + .callback = blacklist_iommu,
> + .ident = "Intel DG33BU",
> + { DMI_MATCH(DMI_BOARD_VENDOR, "Intel Corporation"),
> + DMI_MATCH(DMI_BOARD_NAME, "DG33BU"),
> + }
> + },

-Andi

--
ak@linux.intel.com


\
 
 \ /
  Last update: 2008-09-02 00:35    [W:0.052 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site