Messages in this thread | | | From | Alan Horstmann <> | Subject | Re: [alsa-devel] [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C | Date | Mon, 1 Sep 2008 14:52:08 +0100 |
| |
We have just started trying this out as an alternative to i2c, and picked out the following:
On Wednesday 27 August 2008 10:39, Bryan Wu wrote: > -#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) > +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) && !defined > (CONFIG_SND_SOC_WM8731_SPI)
I think this needs extra brackets round the ||'s before the && thus:
> +#if (defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)) && !defined > (CONFIG_SND_SOC_WM8731_SPI)
in order to force use of SPI when (CONFIG_SND_SOC_WM8731_SPI) and (CONFIG_I2C) are both defined. Or have we misunderstood the intention? This is in 2 other places also in the patch.
Alan
| |