lkml.org 
[lkml]   [2008]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage

    It would be easy to constify the expression but I have removed
    the BUILD_BUG_ON. (Left the useful comment though). Since
    it has no point here, a BUILD_BUG_ON is used when two
    inter-dependent but separate pieces of code must match. which
    is not the case here.

    Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
    CC: David S. Miller <davem@davemloft.net>
    ---
    drivers/net/niu.c | 8 +++-----
    1 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/niu.c b/drivers/net/niu.c
    index e4765b7..b517d0c 100644
    --- a/drivers/net/niu.c
    +++ b/drivers/net/niu.c
    @@ -5135,17 +5135,15 @@ static void niu_init_tx_mac(struct niu *np)
    {
    u64 min, max;

    + /* NOTE: XMAC_MIN register only accepts values for TX min which
    + * have the low 3 bits cleared.
    + */
    min = 64;
    if (np->dev->mtu > ETH_DATA_LEN)
    max = 9216;
    else
    max = 1522;

    - /* The XMAC_MIN register only accepts values for TX min which
    - * have the low 3 bits cleared.
    - */
    - BUILD_BUG_ON(min & 0x7);
    -
    if (np->flags & NIU_FLAGS_XMAC)
    niu_init_tx_xmac(np, min, max);
    else
    --
    1.5.6.rc1.5.gadf6



    \
     
     \ /
      Last update: 2008-09-01 15:15    [W:0.022 / U:30.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site