lkml.org 
[lkml]   [2008]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [01/03] USB: add CONFIG_USB_DEBUG_MESSAGES and usb_dbg()
    On Sat, Aug 09, 2008 at 05:04:43PM +0200, Marcin Slusarz wrote:
    > On Fri, Aug 08, 2008 at 06:39:17PM -0700, Greg KH wrote:
    > > --- a/drivers/usb/core/usb.h
    > > +++ b/drivers/usb/core/usb.h
    > > @@ -132,6 +132,28 @@ static inline int is_active(const struct
    > > /* for labeling diagnostics */
    > > extern const char *usbcore_name;
    > >
    > > +/* USB debugging */
    > > +/* if debug is on or not for the USB core */
    > > +extern int usb_debug;
    > > +
    > > +#if defined(CONFIG_USB_DEBUG_MESSAGES)
    > > +/* macro for debugging */
    > > +#define usb_dbg(dev, format, arg...) \
    > > + ({ \
    > > + if (usb_debug) \
    >
    > maybe unlikely here?

    Does it really generate better code?

    I really dislike using unlikely except for fast paths.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2008-08-10 05:41    [W:0.045 / U:60.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site