[lkml]   [2008]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/5] ftrace: to kill a daemon

On Fri, 8 Aug 2008, Mathieu Desnoyers wrote:
> * Steven Rostedt ( wrote:
> >
> > I originally used jumps instead of nops, but unfortunately, they actually
> > hurt performance more than adding nops. Ingo told me it was probably due
> > to using up the jump predictions of the CPU.
> >
> Hrm, are you sure you use a single 5-bytes nop instruction then, or do
> you use a mix of various nop sizes (add_nops) on some architectures ?

I use (for x86) what is in include/asm-x86/nops.h depending on what the
cpuid gives us.

> You can consume the branch prediction buffers for conditional branches,
> but I doubt static jumps have this impact ? I don't see what "jump
> predictions" you are referring to here exactly.

I don't know the details, but we definitely saw a drop in preformance
between using nops and static jumps.

-- Steve

 \ /
  Last update: 2008-08-08 19:39    [W:0.140 / U:3.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site