lkml.org 
[lkml]   [2008]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] ftrace: enable mcount recording for modules

On Fri, 8 Aug 2008, Rusty Russell wrote:

> On Friday 08 August 2008 04:20:16 Steven Rostedt wrote:
> > This patch enables the loading of the __mcount_section of modules and
> > changing all the callers of mcount into nops.
> >
> > The modification is done before the init_module function is called, so
> > again, we do not need to use kstop_machine to make these changes.
>
> Importantly, before parameter parsing too (which can use module functions
> before the module's init()).

It happens before "module_finalize", so I'm guessing it is also before
parameter passing.

Even if we did it after parameter passing, as long as the code does not
run on another CPU we are fine. Unless the module is setting up interrupt
handlers or kicking off kernel threads, doing the change after parameter
passing would not hurt.

But it looks like we are doing it before that anyway, so it is not an
issue.

Thanks,

-- Steve



\
 
 \ /
  Last update: 2008-08-08 14:53    [W:0.121 / U:5.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site