Messages in this thread | | | Date | Fri, 8 Aug 2008 13:09:06 +0300 (EEST) | From | Vesa-Matti J Kari <> | Subject | Re: [PATCH] selinux: conditional expression type validation was off-by-one |
| |
Hello,
On Thu, 7 Aug 2008, James Morris wrote:
> On Wed, 6 Aug 2008, Vesa-Matti Kari wrote: > > > expr_isvalid() in conditional.c was off-by-one and allowed > > invalid expression type COND_LAST. However, it is this header file > > that needs to be fixed. That way the if-statement's disjunction's > > second component reads more naturally, "if expr type is greater than > > the last allowed value" ( rather than using ">=" in conditional.c): > > > > if (expr->expr_type <= 0 || expr->expr_type > COND_LAST) > > > > Signed-off-by: Vesa-Matti Kari <vmkari@cc.helsinki.fi> > > Thanks, nice catch. > > Applied to > git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
I also checked out the userspace and the same bug exists in libsepol.
Best regards, vmk -- ************************************************************************ Tietotekniikkaosasto / Helsingin yliopisto IT Department / University of Helsinki ************************************************************************
| |