lkml.org 
[lkml]   [2008]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]Fix broken VMI in 2.6.27-rc..
Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> The fixmap area should never have been made movable. It's utter
>> braindamage.
>
> Shrug. It's been like that for a couple of years now. It was one of
> the very first paravirt-ops patches. It wasn't controversial then, and
> nobody seems to have noticed since.

The Linux kernel was never a paragon of perfection - it was never meant
to be. Just because a bit of cruft went unnoticed into the kernel
doesn't mean we shouldn't fix it.

>> Given the x86 architecture, it's inevitable that PV will want to
>> reserve address space at the top of memory, and therefore the fixmap
>> area needs to be moved out of that space.
>
> OK. But there's a few places where the code uses FIXADDR_TOP to mean
> "top of kernel address space", so we'd need to come up with a proper
> symbol for that.

I suggest KERNEL_TOP.

-hpa



\
 
 \ /
  Last update: 2008-08-08 01:57    [W:0.065 / U:50.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site