Messages in this thread | | | Date | Thu, 7 Aug 2008 10:12:46 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set |
| |
Hi!
> > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used > > > > > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > > > Cc: Glauber Costa <gcosta@redhat.com> > > > Cc: Pavel Machek <pavel@suse.cz> > > > Cc: Ingo Molnar <mingo@elte.hu> > > > --- > > > arch/x86/kernel/acpi/sleep.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c > > > index fa2161d..9103cb6 100644 > > > --- a/arch/x86/kernel/acpi/sleep.c > > > +++ b/arch/x86/kernel/acpi/sleep.c > > > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags; > > > /* address in low memory of the wakeup routine. */ > > > static unsigned long acpi_realmode; > > > > > > -#ifdef CONFIG_64BIT > > > +#ifdef CONFIG_SMP > > > static char temp_stack[10240]; > > > #endif > > > > > > > Now it still generates the warning, but on i386 with CONFIG_SMP set, > > instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both > > CONFIG_64BIT and CONFIG_SMP are activated. > > Yes. Thanks for looking at the patch! > > --- > From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001 > From: Marcin Slusarz <marcin.slusarz@gmail.com> > Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > Cc: Glauber Costa <gcosta@redhat.com>
Acked-by: Pavel Machek <pavel@suse.cz>
Ingo, can you merge this one?
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |