lkml.org 
[lkml]   [2008]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] isight_firmware : Fix a leak and double kfree()
Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>

--- linux-2.6/drivers/usb/misc/isight_firmware.c 2008-07-29
23:26:24.000000000 -0400
+++ linux-2.6-wk/drivers/usb/misc/isight_firmware.c 2008-08-07
13:23:01.000000000 -0400
@@ -48,7 +48,8 @@

if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {
printk(KERN_ERR "Unable to load isight firmware\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto out;
}

ptr = firmware->data;
@@ -91,7 +92,6 @@
buf, llen, 300) != llen) {
printk(KERN_ERR
"Failed to load isight firmware\n");
- kfree(buf);
ret = -ENODEV;
goto out;
}

\
 
 \ /
  Last update: 2008-08-07 19:37    [W:0.030 / U:36.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site